Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Feb 2007 11:21:29 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 114168 for review
Message-ID:  <200702071121.l17BLTQ1050821@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=114168

Change 114168 by rwatson@rwatson_cinnamon on 2007/02/07 11:20:57

	Move zeroing of *bz outside of locked region since the locks are
	not required to zero the ioctl argument structure.

Affected files ...

.. //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#18 edit

Differences ...

==== //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#18 (text+ko) ====

@@ -584,8 +584,8 @@
 {
 	struct zbuf *bzh;
 
+	bzero(bz, sizeof(*bz));
 	BPFD_LOCK(d);
-	bzero(bz, sizeof(*bz));
 	if (d->bd_hbuf == NULL && d->bd_slen != 0) {
 		ROTATE_BUFFERS(d);
 		bzh = (struct zbuf *)d->bd_hbuf;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702071121.l17BLTQ1050821>