Date: Tue, 24 Jun 2014 10:07:55 -0600 From: Warner Losh <imp@bsdimp.com> To: "Andrey A. Chernov" <ache@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r267758 - head Message-ID: <256E890F-9564-4741-A5D8-89543381CF2D@gmail.com> In-Reply-To: <201406230054.s5N0suIA081734@svn.freebsd.org> References: <201406230054.s5N0suIA081734@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jun 22, 2014, at 6:54 PM, Andrey A. Chernov <ache@FreeBSD.org> wrote: > Author: ache > Date: Mon Jun 23 00:54:56 2014 > New Revision: 267758 > URL: http://svnweb.freebsd.org/changeset/base/267758 >=20 > Log: > Change suggestion how to set MAKESYSPATH as broken incremental build > workaround. Magic ".../share/mk" (search directories up to /) > does not work for f.e. /usr/src/gnu/lib/libgcc because the path > inside is starting from /usr/obj hierarchy and ends up in > /usr/share/mk, not in the /usr/src/share/mk where src.opts.mk is. > IMHO proper fixing of incremental build is needed urgently. I don=92t understand how this is even possible. This change is wrong = because it has a bogus path the doesn=92t exist on all systems. I=92m = going to fix that. Agreed on incremental builds, but that is turning out to be harder than = expected. It is broken, but adding broken advise is even worse. Warner > Modified: > head/UPDATING >=20 > Modified: head/UPDATING > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/UPDATING Sun Jun 22 23:40:20 2014 (r267757) > +++ head/UPDATING Mon Jun 23 00:54:56 2014 (r267758) > @@ -67,7 +67,7 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 11 > behavior back, you can .include /etc/src.conf from = /etc/make.conf > (which is still global and isn't changed). This also changes the > behavior of incremental builds inside the tree of individual > - directories. Set MAKESYSPATH to ".../share/mk" to do that. > + directories. Set MAKESYSPATH to "/usr/src/share/mk" to do that. > Although this has survived make universe and some upgrade = scenarios, > other upgrade scenarios may have broken. At least one form of > temporary breakage was fixed with MAKESYSPATH settings for = buildworld >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?256E890F-9564-4741-A5D8-89543381CF2D>