Date: Mon, 11 Sep 2017 12:00:12 +0200 From: Marcin Wojtas <mw@semihalf.com> To: Andrew Turner <andrew@fubar.geek.nz> Cc: Marcin Wojtas <mw@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323362 - in head/sys: conf dev/neta Message-ID: <CAPv3WKekRBTi62vu5-9M1OCy8GQN%2BQf6F-tm_1w6BTHBVyCkYw@mail.gmail.com> In-Reply-To: <30B40281-5114-4C72-A9F2-408342BA8216@fubar.geek.nz> References: <201709091154.v89Bs4b9094975@repo.freebsd.org> <30B40281-5114-4C72-A9F2-408342BA8216@fubar.geek.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
2017-09-11 11:38 GMT+02:00 Andrew Turner <andrew@fubar.geek.nz>: > >> On 9 Sep 2017, at 12:54, Marcin Wojtas <mw@FreeBSD.org> wrote: >> >> Author: mw >> Date: Sat Sep 9 11:54:04 2017 >> New Revision: 323362 >> URL: https://svnweb.freebsd.org/changeset/base/323362 >> >> Log: >> Add support for Armada 3700 in the NETA driver >> >> This patch enables using NETA driver on Marvell Armada 3700 SoC >> by introducing new compatible string, modifying clock source >> obtaining and also excluding unnecessary parts. >> The driver is added as a build option for arm64 platforms as well. > > I=E2=80=99m getting the following when trying to build with gcc (I have i= nitial patches to build arm64 with gcc form ports). > > Andrew > > --- if_mvneta.o --- > /jenkins/workspace/FreeBSD-arm64-head-gcc/freebsd-head/sys/dev/neta/if_mv= neta.c:101:1: error: function declaration isn't a prototype [-Werror=3Dstri= ct-prototypes] > mvneta_get_clk() > ^~~~~~~~~~~~~~ > /jenkins/workspace/FreeBSD-arm64-head-gcc/freebsd-head/sys/dev/neta/if_mv= neta.c: In function 'mvneta_detach': > /jenkins/workspace/FreeBSD-arm64-head-gcc/freebsd-head/sys/dev/neta/if_mv= neta.c:834:16: warning: variable 'ifp' set but not used [-Wunused-but-set-v= ariable] > struct ifnet *ifp; > ^~~ > Can you apply below and confirm it helps? https://pastebin.com/8kfdnMz3 If yes, I'll issue a commit with fix. Marcin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPv3WKekRBTi62vu5-9M1OCy8GQN%2BQf6F-tm_1w6BTHBVyCkYw>