Date: Fri, 01 Oct 2021 09:24:31 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64* Message-ID: <sfxl-b428-wny@FreeBSD.org> In-Reply-To: <YVYq4DdMrnK6QTxI@KGPE-D16> (Piotr Kubaj's message of "Thu, 30 Sep 2021 23:23:44 %2B0200") References: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org> <y27d-6dxe-wny@FreeBSD.org> <YVYq4DdMrnK6QTxI@KGPE-D16>
next in thread | previous in thread | raw e-mail | index | archive | help
Piotr Kubaj <pkubaj@anongoth.pl> writes: > On 21-09-30 21:50:21, Jan Beich wrote: >> Piotr Kubaj <pkubaj@FreeBSD.org> writes: >> >> > The include in cpu.cc is not actually necessary, so I did not include anything for FreeBSD. >> [...] >> > +--- tools/cpu/cpu.cc.orig 2021-09-30 15:38:45 UTC >> > ++++ tools/cpu/cpu.cc >> > +@@ -19,7 +19,9 @@ >> > + #endif >> > + >> > + #if JXL_ARCH_PPC >> > +-#include <sys/platform/ppc.h> // __ppc_get_timebase_freq >> > ++#if linux >> > ++#include <sys/platform/ppc.h> // NOLINT __ppc_get_timebase_freq >> > ++#endif >> > + #endif >> >> Can you file a bug via https://github.com/libjxl/libjxl/issues/new ? >> That include is probably unused even on Linux after 5175d11717f3 >> removed __ppc_get_timebase_freq. >> >> Note, if you can't sign Google CLA don't submit a fix. Otherwise, upstream >> will refuse to read the rationale (PR description), let alone the patch e.g., >> https://github.com/libjxl/libjxl/pull/193 > > No, I don't have a Google account. It's not necessary for filing a bug. Doing so on your behalf is complicated by not having powerpc64 hardware to verify fixes proposed upstream and not having an error log/excerpt for upstream to better understand what needs to be changed. Outside of CLA upstream is very helpful. FreeBSD is officially supported (see JXL_OS_FREEBSD) and fixed timely e.g., https://gitlab.com/wg1/jpeg-xl/-/issues/65 https://gitlab.com/wg1/jpeg-xl/-/issues/66
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?sfxl-b428-wny>