Date: Thu, 10 Jan 2008 17:00:33 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_socket.c Message-ID: <20080111010033.GC52842@elvis.mu.org> In-Reply-To: <200801102336.m0ANa0mP035046@repoman.freebsd.org> References: <200801102336.m0ANa0mP035046@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* John Baldwin <jhb@FreeBSD.org> [080110 15:33] wrote: > jhb 2008-01-10 23:36:00 UTC > > FreeBSD src repository > > Modified files: > sys/nfsclient nfs_socket.c > Log: > Pass curthread to various socket routines (socreate(), sobind(), and > soconnect()) instead of &thread0 when establishing a connection to the NFS > server. Otherwise inconsistent credentials may be used when setting up > the NFS socket. I'm not sure, but I think this may be a regression, I seem to recall that a long time ago it was switched to &thread0 because otherwise certain operations can fail due to curthread not running as root. Rev 1.73 of this file might have some clues. I think something weird with ipfw+uid rules can happen with curthread rather than thread0, but I might be mistaking 1.73 for some other change. > > MFC after: 1 week > Reviewed by: rwatson > > Revision Changes Path > 1.156 +1 -1 src/sys/nfsclient/nfs_socket.c -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080111010033.GC52842>