Date: Tue, 19 Aug 2014 01:12:12 +0400 From: Sergey Kandaurov <pluknet@freebsd.org> To: Alexander Kabaev <kabaev@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Scott Long <scottl@freebsd.org> Subject: Re: svn commit: r270149 - head/sys/geom Message-ID: <CAE-mSOKDKe%2BHarGUt-HLEztqLRxEQD4qitmKaHAp7FAiT81LHQ@mail.gmail.com> In-Reply-To: <20140818160554.121e16e7@kan> References: <201408181927.s7IJRm9P048886@svn.freebsd.org> <CAE-mSOKjPSuNPUKMjnzL8sfu7aSoW30qG1bVRawp0vPchNYCoA@mail.gmail.com> <20140818160554.121e16e7@kan>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 August 2014 00:05, Alexander Kabaev <kabaev@gmail.com> wrote: > On Mon, 18 Aug 2014 23:51:32 +0400 > Sergey Kandaurov <pluknet@freebsd.org> wrote: > >> On 18 August 2014 23:27, Scott Long <scottl@freebsd.org> wrote: >> > Author: scottl >> > Date: Mon Aug 18 19:27:47 2014 >> > New Revision: 270149 >> > URL: http://svnweb.freebsd.org/changeset/base/270149 >> > >> > Log: >> > Deal explicitly with possible failures of make_dev_alias_p() in >> > GEOM. >> > >> > Submitted by: Mariusz Zaborski <oshogbo@FreeBSD.org> >> > MFC after: 3 days >> > >> > Modified: >> > head/sys/geom/geom_dev.c >> > >> > Modified: head/sys/geom/geom_dev.c >> > ============================================================================== >> > --- head/sys/geom/geom_dev.c Mon Aug 18 18:07:28 2014 >> > (r270148) +++ head/sys/geom/geom_dev.c Mon Aug 18 19:27:47 >> > 2014 (r270149) >> [...] >> > @@ -263,6 +264,7 @@ g_dev_taste(struct g_class *mp, struct g >> > if (adev != NULL) { >> > adev->si_iosize_max = MAXPHYS; >> > adev->si_drv2 = cp; >> > + adev->si_flags |= SI_UNMAPPED; >> > } >> > >> > g_dev_attrchanged(cp, "GEOM::physpath"); >> > >> >> This part looks unrelated. >> > > Commit says that it deals with consequences of make_dev_alias_p > failing. Preventing trap happening on said failure seems to be > pretty much related to the stated goal. I missed setting SI_UNMAPPED was already there, nevermind. -- wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSOKDKe%2BHarGUt-HLEztqLRxEQD4qitmKaHAp7FAiT81LHQ>