Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Mar 2006 22:08:57 GMT
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 94264 for review
Message-ID:  <200603292208.k2TM8vj8077694@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=94264

Change 94264 by marcel@marcel_nfs on 2006/03/29 22:08:51

	Fix braino: We keep track of line signal changes even if
	the device isn't open. This means that when a device gets
	opened, sc_ttypend may not be 0 and we will therefore
	never schedule the SWI. Do what I intended and limit the
	test to the interrupt pending bits.

Affected files ...

.. //depot/projects/uart/dev/uart/uart_core.c#50 edit

Differences ...

==== //depot/projects/uart/dev/uart/uart_core.c#50 (text+ko) ====

@@ -84,7 +84,7 @@
 		new = old | ipend;
 	} while (!atomic_cmpset_32(&sc->sc_ttypend, old, new));
 
-	if (old == 0)
+	if ((old & SER_INT_MASK) == 0)
 		swi_sched(sc->sc_softih, 0);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603292208.k2TM8vj8077694>