Date: Tue, 29 May 2018 10:00:20 -0400 From: Ed Maste <emaste@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Cy Schubert <Cy.Schubert@cschubert.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include Message-ID: <CAPyFy2Bc099-4Vr1u_MnnvXO93_EGGLOkiTLzqBYKFskZXxfmw@mail.gmail.com> In-Reply-To: <168f4cd3-07d2-15cb-9cf4-a2d02f6dc260@selasky.org> References: <201805291302.w4TD2bR5059884@slippy.cwsent.com> <168f4cd3-07d2-15cb-9cf4-a2d02f6dc260@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 May 2018 at 09:10, Hans Petter Selasky <hps@selasky.org> wrote: > > I only tested buildkernel i386 LINT + GENERIC with this change. I will have > a look ASAP. On IRC the suggestion was made to run buildworld for any header change, and I think this seems like a reasonable standard. Our full buildworld times are admittedly quite long, so if you have a suitably up-to-date toolchain on the build host you can skip building toolchain components with something like: make -DWITHOUT_TOOLCHAIN -DWITHOUT_CLANG_BOOTSTRAP -DWITHOUT_LLD_BOOTSTRAP buildworld That should give much of the build coverage benefit without taking so long. On my little NUC desktop (with -j8) this took about 30 minutes. In addition many folks have put a lot of effort into making non-clean builds work - both meta-mode and conventional. I've generally been building with -DNO_CLEAN for a few years now. The same build with -DNO_CLEAN added and after `touch atomic.h` (again on the NUC) took about 3 minutes.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2Bc099-4Vr1u_MnnvXO93_EGGLOkiTLzqBYKFskZXxfmw>