Date: Sun, 01 Mar 1998 10:09:08 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Mike Smith <mike@smith.net.au> Cc: Bruce Evans <bde@zeta.org.au>, cvs-committers@FreeBSD.ORG, msmith@FreeBSD.ORG Subject: Re: cvs commit: src/sys/gnu/ext2fs ext2_vnops.c Message-ID: <4618.888743348@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 28 Feb 1998 17:34:31 PST." <199803010134.RAA06838@dingo.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199803010134.RAA06838@dingo.cdrom.com>, Mike Smith writes: >> > Modified files: >> > sys/gnu/ext2fs ext2_vnops.c >> > Log: >> > Add local stup putpages/getpages routines. >> > Submitted by: Terry Lambert <terry@freebsd.org> >> >> I think putpages/getpages should go in default_vnodeop_entries[] like >> dima suggested. >> >> Anyway, the patch was not suitable for committing verbatim, because it >> has many style bugs, starting with disordering of lists recently sorted >> by phk. > >Aside from the issue of parenthesised arguments to return, what other >style violations are you aware of? > >I see no 'recent sorting' activity by phk in the affected file, nor any >clear ordering to the only thing in the file that could reasonably be >described as a list. Search for "VOP" in the committers log. It happened some months ago when I spent a great deal of time avoiding identical VOP implementations in multiple filesystems. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "Drink MONO-tonic, it goes down but it will NEVER come back up!" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4618.888743348>