Date: Tue, 6 Sep 2005 17:03:41 +0300 From: Giorgos Keramidas <keramida@freebsd.org> To: Craig Rodrigues <rodrigc@crodrigues.org> Cc: rodrigc@freebsd.org, freebsd-current@freebsd.org, mirya@matrix.kiev.ua, Slawa Olhovchenkov <slw@zxy.spb.ru> Subject: Re: moused related panic Message-ID: <20050906140340.GA27780@orion.daedalusnetworks.priv> In-Reply-To: <20050906133221.GA903@crodrigues.org> References: <20050903133344.GA633@gothmog.gr> <20050905162713.GA92142@crodrigues.org> <20050905175826.GL69481@zxy.spb.ru> <20050906015418.GA590@gothmog.gr> <20050906120809.GP69481@zxy.spb.ru> <20050906124508.GA27413@orion.daedalusnetworks.priv> <20050906133221.GA903@crodrigues.org>
index | next in thread | previous in thread | raw e-mail
On 2005-09-06 09:32, Craig Rodrigues <rodrigc@crodrigues.org> wrote:
> On Tue, Sep 06, 2005 at 03:45:08PM +0300, Giorgos Keramidas wrote:
> > I don't really like the "hackish" way my last patch avoids the panics, because
> > assuming that a default font_width of 8 is ok is probably one gratuitous
> > assumption too many. I haven't had a chance to look at the font changing
> > implementation to see if scp->font_width can be set elsewhere to a non-zero
> > value or if it's supposed to be zero in text modes.
>
> Can you try this:
>
> Index: scvidctl.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/syscons/scvidctl.c,v
> retrieving revision 1.35
> diff -u -u -r1.35 scvidctl.c
> --- scvidctl.c 30 Aug 2005 18:58:16 -0000 1.35
> +++ scvidctl.c 6 Sep 2005 13:31:30 -0000
> @@ -145,6 +145,8 @@
> return ENODEV;
>
> /* adjust argument values */
> + if (fontwidth <= 0)
> + fontwidth = info.vi_cwidth;
> if (fontsize <= 0)
> fontsize = info.vi_cheight;
> if (fontsize < 14) {
This looks promising. I'll try it out, after reverting my local patch
in a while.
Thanks :)
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050906140340.GA27780>