Date: Wed, 30 Nov 2011 23:00:41 +0400 From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: Chris Rees <crees@freebsd.org> Cc: freebsd-rc@freebsd.org Subject: Re: rc-script review request Message-ID: <4ED67D59.9080903@yandex.ru> In-Reply-To: <CADLo8389zeK7G37QwGYfzXJNZU3sZ5quwVYNx4b%2BK7AsR-8q1A@mail.gmail.com> References: <4ED66DCB.1040102@yandex.ru> <CADLo83-RR945MKbdvpdghHsHpO1_MA4OA21WkA_3xCTjOOhDsQ@mail.gmail.com> <4ED67B8F.50109@yandex.ru> <CADLo8389zeK7G37QwGYfzXJNZU3sZ5quwVYNx4b%2BK7AsR-8q1A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Chris Rees wrote on 30.11.2011 22:55:
> On 30 November 2011 18:53, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wrote:
>> Chris Rees wrote on 30.11.2011 22:15:
>>> On 30 November 2011 17:54, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wrote:
>>>> Hello.
>>>>
>>>> I'm planning to finish repocopy of www/zope213 this evening. Would you
>>>> please review rc-script that is supplied with it [1]?
>>>>
>>>> I get this one from www/zope211 and minimally changed it, and as far i
>>>> can tell dougb@ was the last person who touched it, so it should be ok,
>>>> but i'm asking for review just for the case.
>>>>
>>>> I'm attached the script in question and provide the link to it for the
>>>> case if mailmain will eat it.
>>>>
>>>> Thank you much in advance.
>>>
>>> I could get yelled at for this, but normally I'd prefer:
>>
>> Please yell, i'm not experienced in rc at all, so i'll be glad any
>> guidance (in any form) to raise it (experience) :). But i thought that
>> it's safe to use existing scripts from the tree.
>>
>>> start_cmd="${name}_start"
>>>
>>> over
>>>
>>> start_cmd="zope213_start".
>>>
>>> Chris
>>
>> Fixed, thank you. I also added `KEYWORD: shutdown' per PH, because of
>> zope starting under non-root user. Is there still any problems in the
>> script? Updated version here:
>>
>> https://github.com/mexicarne/zope/blob/master/www/zope213/files/zope213.in
>
> I'm not going to sign you off on it, but it looks OK to me.
>
> Doug will be back soon :)
>
> Chris
Og, waiting for Doug then.
--
Regards,
Ruslan
Tinderboxing kills... the drives.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ED67D59.9080903>