Date: Mon, 28 Aug 2023 10:34:47 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: Question about KBI change / new feature Message-ID: <8BA46336-3E51-42E7-BD95-CA3A44B9E623@FreeBSD.org> In-Reply-To: <CANCZdfrYP13UbM-8Qsz17u3_roPuf=3cjvLYZwTgHaQaERnhJw@mail.gmail.com> References: <BC942A68-80BE-45B7-8CC2-E79D9139A86C@FreeBSD.org> <CANCZdfrYP13UbM-8Qsz17u3_roPuf=3cjvLYZwTgHaQaERnhJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Aug 23, 2023, at 1:06 AM, Warner Losh <imp@bsdimp.com> wrote: > > > > On Mon, Aug 21, 2023 at 9:42 AM Zhenlei Huang <zlei@freebsd.org <mailto:zlei@freebsd.org>> wrote: > Hi, > > The https://www.freebsd.org/releases/14.0R/schedule/ <https://www.freebsd.org/releases/14.0R/schedule/>; says CURRENT/14 's KBI is froze > and new features should be avoided. > > I'm working on https://reviews.freebsd.org/D39638 <https://reviews.freebsd.org/D39638>; (sysctl(9): Enable vnet sysctl variables be loader tunable) > and I think it is new feature, but not quite sure whether the KBI changed. > > So, > > 1. Is it a KBI change ? > > IMHO, It's a KPI change, not a KBI breakage. So from that perspective, it's OK. Thanks for the explanation ! > > 2. It is a simple change ( while so far as I know currently only tested by myself on x86 and qemu riscv ), can > it catch up with 14 ? > > That I'm less sure of. I think it's good, but I'm gun shy about approving / committing vnet things. The review suggests, > though, there's at least some consensus for having this in the tree. I always hesitate to PING someone to review ;) Well I'm going to prepare to commit some of the stack, D41525, D39638, D39852, D39866, if no objections. As for D40127, I have mixed filling about it. It might be too complex (for a simple function). I wonder if we can have per-vnet `loader tunnable` to archive the same goal. Best regards, Zhenlei [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Aug 23, 2023, at 1:06 AM, Warner Losh <<a href="mailto:imp@bsdimp.com" class="">imp@bsdimp.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 21, 2023 at 9:42 AM Zhenlei Huang <<a href="mailto:zlei@freebsd.org" class="">zlei@freebsd.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br class=""> <br class=""> The <a href="https://www.freebsd.org/releases/14.0R/schedule/" rel="noreferrer" target="_blank" class="">https://www.freebsd.org/releases/14.0R/schedule/</a>; says CURRENT/14 's KBI is froze<br class=""> and new features should be avoided.<br class=""> <br class=""> I'm working on <a href="https://reviews.freebsd.org/D39638" rel="noreferrer" target="_blank" class="">https://reviews.freebsd.org/D39638</a>; (sysctl(9): Enable vnet sysctl variables be loader tunable)<br class=""> and I think it is new feature, but not quite sure whether the KBI changed.<br class=""> <br class=""> So,<br class=""> <br class=""> 1. Is it a KBI change ?<br class=""></blockquote><div class=""><br class=""></div><div class="">IMHO, It's a KPI change, not a KBI breakage. So from that perspective, it's OK.</div></div></div></div></blockquote><div><br class=""></div><div>Thanks for the explanation !</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> 2. It is a simple change ( while so far as I know currently only tested by myself on x86 and qemu riscv ), can<br class=""> it catch up with 14 ?</blockquote><div class=""><br class=""></div><div class="">That I'm less sure of. I think it's good, but I'm gun shy about approving / committing vnet things. The review suggests,</div><div class="">though, there's at least some consensus for having this in the tree.</div></div></div></div></blockquote><div><br class=""></div><div>I always hesitate to PING someone to review ;)</div><div><br class=""></div><div>Well I'm going to prepare to commit some of the stack, D41525, D39638, D39852, D39866, if no objections.</div><div><br class=""></div><div>As for D40127, I have mixed filling about it. It might be too complex (for a simple function).</div><div>I wonder if we can have per-vnet `loader tunnable` to archive the same goal.</div><div><br class=""></div></div><div class=""><div>Best regards,</div><div>Zhenlei</div> </div> <br class=""></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8BA46336-3E51-42E7-BD95-CA3A44B9E623>