Date: Mon, 28 Aug 2023 10:34:47 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: Question about KBI change / new feature Message-ID: <8BA46336-3E51-42E7-BD95-CA3A44B9E623@FreeBSD.org> In-Reply-To: <CANCZdfrYP13UbM-8Qsz17u3_roPuf=3cjvLYZwTgHaQaERnhJw@mail.gmail.com> References: <BC942A68-80BE-45B7-8CC2-E79D9139A86C@FreeBSD.org> <CANCZdfrYP13UbM-8Qsz17u3_roPuf=3cjvLYZwTgHaQaERnhJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_55D912F6-199E-4A8F-8E91-B293242E36A3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 23, 2023, at 1:06 AM, Warner Losh <imp@bsdimp.com> wrote: >=20 >=20 >=20 > On Mon, Aug 21, 2023 at 9:42=E2=80=AFAM Zhenlei Huang = <zlei@freebsd.org <mailto:zlei@freebsd.org>> wrote: > Hi, >=20 > The https://www.freebsd.org/releases/14.0R/schedule/ = <https://www.freebsd.org/releases/14.0R/schedule/>; says CURRENT/14 's = KBI is froze > and new features should be avoided. >=20 > I'm working on https://reviews.freebsd.org/D39638 = <https://reviews.freebsd.org/D39638>; (sysctl(9): Enable vnet sysctl = variables be loader tunable) > and I think it is new feature, but not quite sure whether the KBI = changed. >=20 > So, >=20 > 1. Is it a KBI change ? >=20 > IMHO, It's a KPI change, not a KBI breakage. So from that perspective, = it's OK. Thanks for the explanation ! > =20 > 2. It is a simple change ( while so far as I know currently only = tested by myself on x86 and qemu riscv ), can > it catch up with 14 ? >=20 > That I'm less sure of. I think it's good, but I'm gun shy about = approving / committing vnet things. The review suggests, > though, there's at least some consensus for having this in the tree. I always hesitate to PING someone to review ;) Well I'm going to prepare to commit some of the stack, D41525, D39638, = D39852, D39866, if no objections. As for D40127, I have mixed filling about it. It might be too complex = (for a simple function). I wonder if we can have per-vnet `loader tunnable` to archive the same = goal. Best regards, Zhenlei --Apple-Mail=_55D912F6-199E-4A8F-8E91-B293242E36A3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Aug 23, 2023, at 1:06 AM, Warner Losh <<a = href=3D"mailto:imp@bsdimp.com" class=3D"">imp@bsdimp.com</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = dir=3D"ltr" class=3D""><div dir=3D"ltr" class=3D""><br = class=3D""></div><br class=3D""><div class=3D"gmail_quote"><div = dir=3D"ltr" class=3D"gmail_attr">On Mon, Aug 21, 2023 at 9:42=E2=80=AFAM = Zhenlei Huang <<a href=3D"mailto:zlei@freebsd.org" = class=3D"">zlei@freebsd.org</a>> wrote:<br class=3D""></div><blockquote= class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex">Hi,<br class=3D""> <br class=3D""> The <a href=3D"https://www.freebsd.org/releases/14.0R/schedule/" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">https://www.freebsd.org/releases/14.0R/schedule/</a>; says = CURRENT/14 's KBI is froze<br class=3D""> and new features should be avoided.<br class=3D""> <br class=3D""> I'm working on <a href=3D"https://reviews.freebsd.org/D39638" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">https://reviews.freebsd.org/D39638</a>; (sysctl(9): Enable = vnet sysctl variables be loader tunable)<br class=3D""> and I think it is new feature, but not quite sure whether the KBI = changed.<br class=3D""> <br class=3D""> So,<br class=3D""> <br class=3D""> 1. Is it a KBI change ?<br class=3D""></blockquote><div class=3D""><br = class=3D""></div><div class=3D"">IMHO, It's a KPI change, not a KBI = breakage. So from that perspective, it's = OK.</div></div></div></div></blockquote><div><br = class=3D""></div><div>Thanks for the explanation !</div><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><div = dir=3D"ltr" class=3D""><div class=3D"gmail_quote"><div = class=3D""> </div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex"> 2. It is a simple change ( while so far as I know currently only tested = by myself on x86 and qemu riscv ), can<br class=3D""> it catch up with 14 ?</blockquote><div class=3D""><br = class=3D""></div><div class=3D"">That I'm less sure of. I think it's = good, but I'm gun shy about approving / committing vnet things. The = review suggests,</div><div class=3D"">though, there's at least some = consensus for having this in the = tree.</div></div></div></div></blockquote><div><br class=3D""></div><div>I= always hesitate to PING someone to review ;)</div><div><br = class=3D""></div><div>Well I'm going to prepare to commit some of the = stack, D41525, D39638, D39852, D39866, if no = objections.</div><div><br class=3D""></div><div>As for D40127, I = have mixed filling about it. It might be too complex (for a simple = function).</div><div>I wonder if we can have per-vnet `loader tunnable` = to archive the same goal.</div><div><br class=3D""></div></div><div = class=3D""><div>Best regards,</div><div>Zhenlei</div> </div> <br class=3D""></body></html>= --Apple-Mail=_55D912F6-199E-4A8F-8E91-B293242E36A3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8BA46336-3E51-42E7-BD95-CA3A44B9E623>