Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 May 1995 19:24:30 +0000 ()
From:      Adam David <adam@veda.is>
To:        rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes)
Cc:        adam@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-gnu@freefall.cdrom.com
Subject:   Re: cvs commit: src/gnu/lib/libreadline display.c
Message-ID:  <199505221924.TAA09678@veda.is>
In-Reply-To: <199505221747.KAA05201@gndrsh.aac.dev.com> from "Rodney W. Grimes" at May 22, 95 10:47:01 am

next in thread | previous in thread | raw e-mail | index | archive | help
> >   Modified:    gnu/lib/libreadline  display.c
> >   Log:
> >   eliminate coredump for readline(NULL) case
> 
> Did I miss a message about code freeze being lifted??? 

Bugfix only, as explicitly permitted by freefall's motd.

> A library is defanitly a critical place to be patching.

There is no change of interface, only an advertised functionality
that dumped core instead of the expected behaviour.

> Reviewd by: ??????

Is this necessary for a trivial bugfix?

old: strlen(local_prompt)
new: local_prompt ? strlen(local_prompt) : 0

local_prompt == NULL  is a valid state, as empty prompts may be represented
as either "" or NULL in the rest of the code.

--
Adam David <adam@veda.is>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199505221924.TAA09678>