Date: Tue, 3 Jul 2001 19:32:14 +0200 From: Joerg Wunsch <j@uriah.heep.sax.de> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bio.h Message-ID: <20010703193214.A3398@uriah.heep.sax.de> In-Reply-To: <200107030615.f636FLU07187@mass.dis.org>; from msmith@FreeBSD.org on Mon, Jul 02, 2001 at 11:15:21PM -0700 References: <200106291521.f5TFLUT83063@freefall.freebsd.org> <200107030615.f636FLU07187@mass.dis.org>
next in thread | previous in thread | raw e-mail | index | archive | help
As Mike Smith wrote:
> > sys/sys bio.h
> > Log:
> > Define BIO_CMD{1,2}, available for local hacks, similar to the already
> > existing BIO_FLAG{1,2}. To be used in the fdc(4) driver soon.
>
> Any reason you're not using the driver-private field instead?
Because i need to fill in a cmd value anyway, and neither of the
existing didn't fit well. Maybe a single CMD_PRIVATE value would have
sufficed, but i rather followed the other examples (CMD_FLAG{1,2}
etc).
Also, using a void * would have complicated matters pretty much. It's
invalid to abuse a void * as an int, so i would have had to malloc a
single 32-bit value somewhere since i can't use a variable located on
the stack, and pass its address down in one of the void * field.
--
cheers, J"org .-.-. --... ...-- -.. . DL8DTL
http://www.sax.de/~joerg/ NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010703193214.A3398>