Date: Mon, 23 Apr 2007 12:40:19 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: "Bruce M. Simpson" <bms@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Gleb Smirnoff <glebius@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/pf/net if_pfsync.c Message-ID: <20070423123711.I26224@fledge.watson.org> In-Reply-To: <462C8FFB.7030309@FreeBSD.org> References: <200704140101.l3E11kum000736@repoman.freebsd.org> <20070423095356.GB2742@FreeBSD.org> <462C8FFB.7030309@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Apr 2007, Bruce M. Simpson wrote: > I agree with you that the current fix is not ideal, however it's the most > appropriate fix for the code as it currently stands. > > I stand by my work, you are free to improve upon it. Part of the issue here is that kernel consumers aren't the only sources of multicast address registrations -- for example, user applications can register them directly using ioctls. Kernel consumers should be given every opportunity to unregister addresses themselves (via event handlers on tear-down) before they are ripped out, but if they're still there when it comes time to free the interface, the stack should clean them up. Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070423123711.I26224>