Date: Sat, 26 Jan 2013 05:41:01 -0800 From: Davide Italiano <davide@freebsd.org> To: hiren panchasara <hiren.panchasara@gmail.com> Cc: Fabien Thomas <fabien.thomas@netasq.com>, freebsd-current <freebsd-current@freebsd.org>, Jim Harris <jim.harris@gmail.com> Subject: Re: hwpmc support for Ivy Bridge Xeon Message-ID: <CACYV=-FE5f1K3QDBTgvhPYF7E1cA%2Bn9hoABWok%2B31GJs0RXUZQ@mail.gmail.com> In-Reply-To: <CALCpEUGHyCpAUs%2BQxfhKC7X6a1h78Ff4fX97rLLTtte0X_se3Q@mail.gmail.com> References: <CALCpEUGHyCpAUs%2BQxfhKC7X6a1h78Ff4fX97rLLTtte0X_se3Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara <hiren.panchasara@gmail.com> wrote: > I've tried to update hwpmc by adding support for xeon class of Ivy > bridge processors. > > Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013) > > I do not have a reference machine to test with. Any help in that > regard would be appreciated. > > Here are the diffs against head (245927): > http://www.strugglingcoder.info/patches/hwpmc_ibx.txt > > Thanks, > Hiren > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >From a first look appears good -- I've a couple of observations though. I see your patch covers only core events -- am I missing something? Not really important, and I don't want to be pedantic here, but maybe this can be renamed to something less ugly: static int -iap_event_sb_sbx_ib_ok_on_counter(enum pmc_event pe, int ri) +iap_event_sb_sbx_ib_ibx_ok_on_counter(enum pmc_event pe, int ri) -- Davide
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-FE5f1K3QDBTgvhPYF7E1cA%2Bn9hoABWok%2B31GJs0RXUZQ>