Date: Tue, 18 Jan 2000 16:41:29 -0500 (EST) From: Brian Fundakowski Feldman <green@FreeBSD.org> To: Kris Kennaway <kris@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/secure/usr.bin/openssl Makefile Message-ID: <Pine.BSF.4.10.10001181631530.36232-100000@green.dyndns.org> In-Reply-To: <200001162100.NAA00953@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 16 Jan 2000, Kris Kennaway wrote:
> kris 2000/01/16 13:00:07 PST
>
> Modified files:
> secure/usr.bin/openssl Makefile
> Log:
> The wrong version of the file was committed previously which explains the
> problems seen here.
Thanks for your continued work here, but there are still problems. In
src/secure/usr.bin/openssl/Makefile, you check for librsaref.a in
${LOCALBASE}/lib, but then use -L${LOCALBASE}/lib -lrsaref. This
seems like the wrong thing to do to me. Since you're checking for
the existence of that specific file, you should use that file, so
the line would be
LDADD+= ${LOCALBASE}/lib/librsaref.a
Without doing that, there are problems. One is that you assume that
${LOCALBASE} is mounted whenever /usr/bin is, and create the dependency
on ${LOCALBASE} for parts of the base system. This is not necessarily
a bad thing to me for compiling code which uses rsaref (so linking
libcrypto from the base with -L${LOCALBASE}/lib -lrsaref should be
fine, IMHO), but the base should be usable in its entirety without
${LOCALBASE}.
Another is that it breaks world for me. Why? Well, I want to have
OpenSSL in ${LOCALBASE}, at least for now. When -L${LOCALBASE}/lib
is added, libraries in that path gain precedence over the standard
ones. So, it links with the wrong library and can't find symbols
it needs.
The solution to this would be:
RCS file: /usr2/ncvs/src/secure/usr.bin/openssl/Makefile,v
--- Makefile 2000/01/16 21:00:06 1.3
+++ Makefile 2000/01/18 21:26:50
@@ -19,3 +19,3 @@
CFLAGS+= -DRSAref
-LDADD+= -L${LOCALBASE}/lib -lrsaref
+LDADD+= ${LOCALBASE}/lib/rsaref.a
.endif
> Revision Changes Path
> 1.3 +18 -5 src/secure/usr.bin/openssl/Makefile
--
Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! /
green@FreeBSD.org `------------------------------'
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.10001181631530.36232-100000>