Date: Wed, 5 Sep 2001 19:34:24 +0300 From: Giorgos Keramidas <charon@labs.gr> To: hackers@freebsd.org Subject: usr.sbin/ac change - request for comments Message-ID: <20010905193424.A686@hades.hell.gr>
index | next in thread | raw e-mail
The code of usr.sbin/ac/ includes support for handling ":0.0" as
console logins, when CONSOLE_TTY is defined during compilation.
Looking at the code, and revisions from 1.2 and up, this doesn't seem
to be used. Is there any reason why this should not be removed from
the sources. It's not used anyway :/
I'm talking about pieces of code like the following:
#ifdef CONSOLE_TTY
static char *Console = CONSOLE_TTY;
#endif
or parts like the even more exotic:
while ((c = getopt(argc, argv, "Dc:dpt:w:")) != -1) {
switch (c) {
...
case 'c':
#ifdef CONSOLE_TTY
Console = optarg;
#else
usage(); /* XXX */
#endif
break;
The code is cluttered all over with #ifdef'ed pieces of code that are
not used. Is it really necessary that we keep these parts?
-giorgos
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010905193424.A686>