Date: Sun, 04 Mar 2018 12:29:28 +0100 From: "Ronald Klop" <ronald-lists@klop.ws> To: "Hans Petter Selasky" <hselasky@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Colin Percival" <cperciva@tarsnap.com> Subject: Re: svn commit: r330236 - head/sys/compat/linuxkpi/common/src Message-ID: <op.zfcnjexlkndu52@klop.ws> In-Reply-To: <01000161ee9cee29-0a02aaff-9052-41d2-a638-4bc673a41df6-000000@email.amazonses.com> References: <201803011031.w21AVpNU076475@repo.freebsd.org> <01000161ee9cee29-0a02aaff-9052-41d2-a638-4bc673a41df6-000000@email.amazonses.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 04 Mar 2018 02:25:17 +0100, Colin Percival <cperciva@tarsnap.com> wrote: > On 03/01/18 02:31, Hans Petter Selasky wrote: >> New Revision: 330236 >> Correct the return value from flush_work() and flush_delayed_work() >> in the >> LinuxKPI to comply more with Linux. This fixes an issue when these >> functions >> are used in waiting loops. >> >> MFC after: 1 week >> Sponsored by: Mellanox Technologies > > In case the data point is useful: Merging this to stable/11 unbroke S3 > suspend/resume on my laptop (system76 Galago Pro, kabylake, using the > drm-next-kmod port). > These data points are much more useful than commit messages that describe what the patch already shows and talk about 'an issue'. Every patch solves 'an issue' (or creates some :-) ). No personal pun intended. Just taking this example as general thoughts about commit messages. Regards, Ronald.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.zfcnjexlkndu52>