Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Jan 2007 14:04:48 +0200 (EET)
From:      Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>
To:        Warner Losh <imp@freebsd.org>
Cc:        cvs-src@freebsd.org
Subject:   Re: cvs commit: src/sys/kern kern_ntptime.c
Message-ID:  <20070112140211.G555@atlantis.atlantis.dp.ua>
In-Reply-To: <200701120740.l0C7eULD026513@repoman.freebsd.org>
References:  <200701120740.l0C7eULD026513@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

Hello!

On Fri, 12 Jan 2007, Warner Losh wrote:
>    sys/kern             kern_ntptime.c
>  Log:
>  When ntp_gettime() was converted from a sysctl + wrapper to a system
>  call, its semantics were unintentionally changed.  It went from
>  returning the time state to returning 0 or -1.  Since 0 means time

   Shouldn't the manpage lib/libc/sys/ntp_gettime.2 also be updated? It claims
now:

RETURN VALUES
      The ntp_gettime() function returns the value 0 if successful; otherwise
      the value -1 is returned and the global variable errno is set to indicate
      the error.

      Possible states of the clock are:
 	...

So it still refers to old behaviour (return either 0 or -1), which is 
confusing enough.

Sincerely, Dmitry
-- 
Atlantis ISP, System Administrator
e-mail:  dmitry@atlantis.dp.ua
nic-hdl: LYNX-RIPE



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070112140211.G555>