Date: Sun, 30 Aug 2009 13:20:04 GMT From: Marc Fonvieille <blackend@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/138341: [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module Message-ID: <200908301320.n7UDK4Z7073899@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/138341; it has been noted by GNATS.
From: Marc Fonvieille <blackend@FreeBSD.org>
To: Eugene Grosbein <eugen@kuzbass.ru>
Cc: FreeBSD-gnats-submit@FreeBSD.org, stable@freebd.org, qa@FreeBSD.org
Subject: Re: kern/138341: [patch] 8.0-BETA3: nanobsd build broken due to sysipc kernel module
Date: Sun, 30 Aug 2009 15:16:25 +0200
On Sun, Aug 30, 2009 at 08:40:07PM +0800, Eugene Grosbein wrote:
> >
> > I suspect it's the problem I met when I tried to do a
> >
> > make -DMODULES_WITH_WORLD="YES" buildworld
> >
> > and many modules were concerned. See the following patch:
> >
> > Index: sys/modules/dtrace/lockstat/Makefile
> > ===================================================================
> > --- sys/modules/dtrace/lockstat/Makefile (revision 196013)
> > +++ sys/modules/dtrace/lockstat/Makefile (working copy)
> > @@ -5,7 +5,7 @@
> > KMOD= lockstat
> > SRCS= lockstat.c
> >
> > -SRCS+= vnode_if.h
> > +SRCS+= vnode_if.h opt_kdtrace.h
> >
> > CFLAGS+= -I${.CURDIR}/../../../cddl/compat/opensolaris \
> > -I${.CURDIR}/../../../cddl/contrib/opensolaris/uts/common \
> > Index: sys/modules/sysvipc/sysvsem/Makefile
> > ===================================================================
> > --- sys/modules/sysvipc/sysvsem/Makefile (revision 196013)
> > +++ sys/modules/sysvipc/sysvsem/Makefile (working copy)
> > @@ -3,6 +3,6 @@
> > .PATH: ${.CURDIR}/../../../kern
> >
> > KMOD= sysvsem
> > -SRCS= sysv_sem.c opt_sysvipc.h
> > +SRCS= sysv_sem.c opt_sysvipc.h opt_compat.h
> >
> > .include <bsd.kmod.mk>
> > Index: sys/modules/sysvipc/sysvmsg/Makefile
> > ===================================================================
> > --- sys/modules/sysvipc/sysvmsg/Makefile (revision 196013)
> > +++ sys/modules/sysvipc/sysvmsg/Makefile (working copy)
> > @@ -3,6 +3,6 @@
> > .PATH: ${.CURDIR}/../../../kern
> >
> > KMOD= sysvmsg
> > -SRCS= sysv_msg.c opt_sysvipc.h
> > +SRCS= sysv_msg.c opt_sysvipc.h opt_compat.h
> >
> > .include <bsd.kmod.mk>
> >
>
> You are right, other modules are concerned and your patch is more complete
> and correct. Vote for commit :-)
>
For info this unbreak things for most of archs but mips and arm which
need more work in sys/modules/Makefile. However we can already commit
this patch.
--
Marc
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908301320.n7UDK4Z7073899>