Date: Sat, 2 Feb 2013 20:04:46 -0800 (PST) From: Pedro Giffuni <pfg@freebsd.org> To: Eitan Adler <eadler@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r246278 - head/usr.sbin/crunch/crunchide Message-ID: <1359864286.77306.YahooMailNeo@web162102.mail.bf1.yahoo.com> In-Reply-To: <CAF6rxg=nEHTUr7dvjHo7ro5790sKDcO%2BMjPc_3r10EMNk_cUsQ@mail.gmail.com> References: <201302030154.r131sQZm084127@svn.freebsd.org> <CAF6rxg=nEHTUr7dvjHo7ro5790sKDcO%2BMjPc_3r10EMNk_cUsQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Eitan;=0A=0A=0A----- Messaggio originale -----=0A> Da: Eitan Adler=A0=0A= =0A> =0A> On 2 February 2013 20:54, Pedro F. Giffuni <pfg@freebsd.org> wrot= e:=0A>> Author: pfg=0A>> Date: Sun Feb=A0 3 01:54:25 2013=0A>> New Revis= ion: 246278=0A>> URL: http://svnweb.freebsd.org/changeset/base/246278=0A>>= =0A>> Log:=0A>> =A0 crunch: Sync some NetBSD changes=0A>> =0A>> =A0 Fix= a couple of free's in previous commit.=0A>> =0A>> =A0 Obtained from:=A0 = =A0 =A0 =A0 NetBSD=0A>> =A0 MFC after:=A0 =A0 1 week=0A>> =0A>> Modified:= =0A>> =A0 head/usr.sbin/crunch/crunchide/exec_elf32.c=0A>> =0A>> Modified= : head/usr.sbin/crunch/crunchide/exec_elf32.c=0A>> =0A> =3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A>> --= - head/usr.sbin/crunch/crunchide/exec_elf32.c Sun Feb=A0 3 01:22:28 2013=A0= =A0 =0A> =A0 =A0 (r246277)=0A>> +++ head/usr.sbin/crunch/crunchide/exec_e= lf32.c Sun Feb=A0 3 01:54:25 2013=A0 =A0 =0A> =A0 =A0 (r246278)=0A>> @@ -3= 84,6 +384,8 @@ out:=0A>> =A0 =A0 =A0 =A0 if (symtabp !=3D NULL)=0A>> =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 free(symtabp);=0A>> =A0 =A0 =A0 =A0 if (strta= bp !=3D NULL)=0A>> +=A0 =A0 =A0 =A0 =A0 =A0 =A0 free(strtabp);=0A>> +=A0= =A0 =A0 if (nstrtabp !=3D NULL)=0A>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 fre= e(nstrtabp);=0A> =0A> Why bother checking for NULL here?=A0 7.22.2.3.2 say= s that free(NULL)=0A> results in no action.=0A>=0A=0AYou are right. I was j= ust copying the NetBSD code blindly.=0A=0AI will clean that tomorrow when I= bring the mclinker fixes.=0A=0APedro.=A0=0A
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1359864286.77306.YahooMailNeo>