Date: Tue, 03 Feb 2009 16:45:15 +0000 From: Gavin Atkinson <gavin@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r188077 - in head/sys/dev: ichsmb ipmi smbus Message-ID: <1233679515.51684.60.camel@buffy.york.ac.uk> In-Reply-To: <200902031614.n13GEbAt034978@svn.freebsd.org> References: <200902031614.n13GEbAt034978@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2009-02-03 at 16:14 +0000, John Baldwin wrote: > Author: jhb > Date: Tue Feb 3 16:14:37 2009 > New Revision: 188077 > URL: http://svn.freebsd.org/changeset/base/188077 > > Log: > - Change ichsmb(4) to follow the format of all the other smbus controllers > for slave addressing by using left-adjusted slave addresses (i.e. > xxxxxxx0b). Thank you! This is kern/100513 (although the PR believed that ichsmb was the correct one, not the one at fault). >From my experience, the way FreeBSD now do it seems to be the "more standard" way, in that I2C datasheets usually give the xxxxxxx0b address as the device address, however NetBSD (at least) seems to use the address in the MSB=0 form. I suspect this is probably worth documenting explicitly somewhere. Gavin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1233679515.51684.60.camel>