Date: Sun, 28 Aug 2011 16:38:01 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: if_ath - should it be compiled without ath_hal support? Message-ID: <CAGH67wSX3d8AM%2B-Qc_M2RfBL_VMyRPB7na_JmNxq2nfb4fL0Bg@mail.gmail.com> In-Reply-To: <CAJ-VmonnTxoWMbRE-PqtoDH1_16OpwK0Jw9hZ6WVkQjnr-JTfw@mail.gmail.com> References: <CAGH67wRz6X=ZU0AZFM1G-fo=NKHNVV7SD547KD-BBp4VOofDaw@mail.gmail.com> <CAJ-VmonnTxoWMbRE-PqtoDH1_16OpwK0Jw9hZ6WVkQjnr-JTfw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 24, 2011 at 10:37 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> Hi,
>
...
> Well, the ath_hal code should be built in as part of the ath module.
> ath needs ath_hal to speak to the MAC/baseband/radio. There's no need
> for #ifdef's to guard them as .. well, they're needed.
Ok.
> I'd like to eventually split out the ath_hal again into a separate
> module and re-instate the separation between HAL and driver code
> (primarily to enforce cleaner code and more stable APIs.)
Good to know. I was just a bit confused with the manpages that say
they're optional after I discovered looking at the driver that they're
hardwired in.
> If you're seeing issues like the above, chances are that you're seeing
> some corruption. Can you please print out the whole value of *rs (ie,
> all the fields of the ath_rx_status struct) so I can see how valid it
> is?
Sure:
(kgdb) p *rs
$1 =3D {rs_datalen =3D 244, rs_status =3D 0 '\0', rs_phyerr =3D 0 '\0',
rs_rssi =3D 0 '\0', rs_keyix =3D 127 '\177', rs_rate =3D 27 '\033', rs_more
=3D 0 '\0', rs_tstamp =3D 2097280, rs_antenna =3D 8399232, rs_rssi_ctl =3D
"0\200)", rs_rssi_ext =3D "\200\000\037", rs_isaggr =3D 1 '\001',
rs_moreaggr =3D 1 '\001', rs_num_delims =3D 0 '\0', rs_flags =3D 252 '=FC',
rs_evm0 =3D 0, rs_evm1 =3D 0, rs_evm2 =3D 0, rs_evm3 =3D 0, rs_evm4 =3D 0}
Thanks!
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wSX3d8AM%2B-Qc_M2RfBL_VMyRPB7na_JmNxq2nfb4fL0Bg>