Date: Sun, 16 Mar 2014 09:39:35 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: Robert Watson <rwatson@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r263215 - head/sys/crypto/sha2 Message-ID: <20140316163935.GD32089@funkthat.com> In-Reply-To: <alpine.BSF.2.00.1403161019360.24702@fledge.watson.org> References: <201403160057.s2G0vQEh074159@svn.freebsd.org> <alpine.BSF.2.00.1403161006130.24702@fledge.watson.org> <alpine.BSF.2.00.1403161019360.24702@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson wrote this message on Sun, Mar 16, 2014 at 10:20 +0000:
> On Sun, 16 Mar 2014, Robert Watson wrote:
>
> >> copy these files from lib/libmd in preperation for moving these files
> >> into the kernel...
> >
> >I was sure that there was a sha256 implementation in the kernel already,
> >and indeed there is -- in the ZFS code. Having it in the crypto tree
> >makes (much) more sense (and I remain surprised it wasn't there already).
> >I wonder if this means we can GC at least the copy in the zfs tree (if not
> >the boot copy as well).
>
> Reading the follow-up commit I now understand better. I do wonder if we
> can drop the ZFS copy, however -- in general, we seem to prefer FreeBSD
> versions of things (e.g., the ACL code) when they are available.
Which one are you talking about?
If you are talking about the one in
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sha256.c, that is just
a wrapper around the one I just improved/replaced...
If you are talking about the one in sys/cddl/boot/zfs/sha256.c, that,
I assume, is part of the boot code, and would require special handling..
plus, boot code doesn't need to run fast, and usually needs to be
smaller, though once I add the option of rolling the loops up, we could
look at that...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140316163935.GD32089>