Date: Tue, 9 Feb 2021 16:49:28 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: af366d353b84 - main - amd64: implement strlen in assembly Message-ID: <CAGudoHGtAJWksUQa4sEMmMUit8F4JOskWC5ejOQMPsAyUTMZeg@mail.gmail.com> In-Reply-To: <83E33E2F-F7FE-4385-8F99-0A7235F87C63@freebsd.org> References: <202102081915.118JFXkJ067892@gitrepo.freebsd.org> <83E33E2F-F7FE-4385-8F99-0A7235F87C63@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/9/21, Jessica Clarke <jrtc27@freebsd.org> wrote: > Here's your review after reading through it for <5 minutes today: > > On 8 Feb 2021, at 19:15, Mateusz Guzik <mjg@FreeBSD.org> wrote: >> + leaq (%r11,%r8),%rcx >> + notq %r11 >> + andq %r11,%rcx >> + andq %r9,%rcx >> ... >> + leaq (%r11,%r8),%rcx >> + notq %r11 >> + andq %rcx,%r11 > > These look the wrong way round (but you got it the right way round > above). > Indeed, solid brainfart. Interesting this still passed the test suite. Thank you for noting this. However, your response does not really address any of the points I raised in my e-mail. >> + andq %r9,%rcx > > Jess > > -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHGtAJWksUQa4sEMmMUit8F4JOskWC5ejOQMPsAyUTMZeg>