Date: Sat, 03 Dec 2022 15:38:49 +0000 From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 267539] Bhyve virtio-scsi warnings about illegal SCSI tag reuse Message-ID: <bug-267539-27103-cPB37j7O3w@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-267539-27103@https.bugs.freebsd.org/bugzilla/> References: <bug-267539-27103@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267539 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D0acc026dda9e7405f7a88993d1b51e5fc= 846cbc5 commit 0acc026dda9e7405f7a88993d1b51e5fc846cbc5 Author: Alexander Motin <mav@FreeBSD.org> AuthorDate: 2022-12-03 15:23:29 +0000 Commit: Alexander Motin <mav@FreeBSD.org> CommitDate: 2022-12-03 15:23:29 +0000 CTL: Increase maximum SCSI tag size from 32 to 64 bits. SAM-5 specification states maximum size of command identifier (tag), defined by specific transports, should not be larger than 64 bits. While most of supported transports use 32 bits or less, it was reported that virtio-scsi uses 64 bits. Truncation to 32 bits in bhyve code caused false tag conflict errors reported and possibly other issues. This changes CTL ABI and HA protocol, so CTL_HA_VERSION is bumped. While we make HA protocol incompatible, increase default maximum number of ports in CTL from 256 to 1024, matching number of LUNs. There are many reports from people who need many iSCSI targets with only one LUN each. Increased memory consumption should be less of a problem these days. PR: 267539 share/man/man4/ctl.4 | 2 +- sys/cam/ctl/ctl.c | 13 +++++++------ sys/cam/ctl/ctl_frontend_ioctl.c | 4 ++-- sys/cam/ctl/ctl_io.h | 11 +++++------ sys/cam/ctl/ctl_ioctl.h | 3 ++- sys/cam/ctl/ctl_tpc_local.c | 2 +- sys/cam/ctl/ctl_util.c | 6 +++--- sys/cam/ctl/scsi_ctl.c | 2 +- usr.sbin/bhyve/pci_virtio_scsi.c | 4 ++-- 9 files changed, 24 insertions(+), 23 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-267539-27103-cPB37j7O3w>