Date: Tue, 12 Feb 2002 04:04:29 +0300 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/security/drweb-sendmail Makefile ports/security/drweb-sendmail/files Makefile.libmilter patch-ab patch-ad Message-ID: <20020212010427.GA93193@nagual.pp.ru> In-Reply-To: <20020212003407.GG82640@squall.waterspout.com> References: <200202112242.g1BMg2I04645@freefall.freebsd.org> <20020212003407.GG82640@squall.waterspout.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 11, 2002 at 19:34:07 -0500, Will Andrews wrote:
> On Mon, Feb 11, 2002 at 02:42:02PM -0800, Andrey A. Chernov wrote:
> > Log:
> > Add -D_THREAD_SAFE, remove libsmutil building
>
> Use CFLAGS+=${PTHREAD_CFLAGS}, not this.
I doubt that PTHREAD_CFLAGS definition for recent -current (as "") is
correct, see include/rpc/clnt.h
Moreover, -D_THREAD_SAFE still in the lib/libc_r/Makefile. All it looks
like it is needed for recent -current too.
> Also, you broke
> guidelines which say you're supposed to use the same patch file
> for the same patched file in the source. In patch-ab's case
> you've patched src/Makefile.bsd when it was dw_filter.c.
patch-ab was removed long time ago.
--
Andrey A. Chernov
http://ache.pp.ru/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020212010427.GA93193>