Date: Wed, 6 Apr 2005 13:42:57 +0200 From: Marc Olzheim <marcolz@stack.nl> To: Uwe Doering <gemini@geminix.org> Cc: freebsd-security@freebsd.org Subject: Re: FreeBSD Security Advisory FreeBSD-SA-05:02.sendfile Message-ID: <20050406114257.GA22448@stack.nl> In-Reply-To: <425248D8.1040508@geminix.org> References: <200504050009.j35099Zr068123@freefall.freebsd.org> <425248D8.1040508@geminix.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 05, 2005 at 10:14:16AM +0200, Uwe Doering wrote: > I can't tell why 'ovp' was introduced in the first place. Might have=20 > historical reasons. But that's how the code currently works. In the=20 > MAIN branch as well, according to CVS. So I'd suggest to replace 'vp'=20 > with 'ovp' in the patch above, for the sake of clarity and consistency. It's a remnant from sys/ufs/ffs/ffs_inode.c:1.27 - 1.28, when the arguments of ffs_truncate changed from (ap), to (vp, length, flags, cred, p) and ovp was declared as 'register struct vnode *vp =3D ap->a_vp;'. This could be cleaned up without problems. Marc --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCU8tBezjnobFOgrERAvSSAKCuM3WCuoL5yn+L0kgtj1UJhkGF/wCeNZz5 twShJMn5nPlYbz+SXGr733c= =iEYG -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050406114257.GA22448>