Date: Sun, 10 Feb 2008 13:49:04 +0100 From: "Attilio Rao" <attilio@freebsd.org> To: "Robert Watson" <rwatson@freebsd.org> Cc: Kostik Belousov <kostikbel@gmail.com>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys lockmgr.h Message-ID: <3bbf2fe10802100449r1b673bbfl3e41a419b08c0@mail.gmail.com> In-Reply-To: <20080210120359.A97821@fledge.watson.org> References: <200802092137.m19Lbsiu098036@repoman.freebsd.org> <20080210113949.GN57756@deviant.kiev.zoral.com.ua> <20080210120359.A97821@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2008/2/10, Robert Watson <rwatson@freebsd.org>: > > On Sun, 10 Feb 2008, Kostik Belousov wrote: > > > On Sat, Feb 09, 2008 at 09:37:54PM +0000, Attilio Rao wrote: > >> attilio 2008-02-09 21:37:54 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/sys lockmgr.h > >> Log: > >> Use LOCK_FILE and LOCK_LINE where necessary instead than __FILE__ and > >> __LINE__ with lockmgr. > >> > >> Revision Changes Path > >> 1.60 +2 -2 src/sys/sys/lockmgr.h > > > > I think this shall be MFCed to RELENG_7 and RELENG_7_0. > > > ... once it no longer breaks the tinderbox? > > BTW, at this point 7.0 is basically closed to any further changes. Anyone > planning on getting things in to 7.x needs to be thinking about either errata > notices (for really critical things) and 7.1. Buh! I'm very sorry for this. Really, this needed to be better croaked. It needs to include sys/lock.h for any lockmgr.h consumer (making lock.h a pre-requirement in lockmgr usage). This is going to be a little bit of work. For the moment I will revert this change, doing a better stub later, once other details about lockmgr are refined. Thanks, Attilio (pointy hat on) -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10802100449r1b673bbfl3e41a419b08c0>