Date: Wed, 15 Jun 2011 17:26:01 +0200 From: Alexey Shuvaev <shuvaev@physik.uni-wuerzburg.de> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Simple tidy up of puc(4) bus driver Message-ID: <20110615152601.GA65255@lexx.ifp.tuwien.ac.at> In-Reply-To: <201106141134.34611.jhb@freebsd.org> References: <201105231039.02845.jhb@freebsd.org> <201106101511.02809.jhb@freebsd.org> <20110614144418.GA38374@lexx.ifp.tuwien.ac.at> <201106141134.34611.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--LQksG6bCIzRHxTLp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Tue, Jun 14, 2011 at 11:34:34AM -0400, John Baldwin wrote:
> On Tuesday, June 14, 2011 10:44:18 am Alexey Shuvaev wrote:
> > On Fri, Jun 10, 2011 at 03:11:02PM -0400, John Baldwin wrote:
> > > On Monday, May 23, 2011 10:39:02 am John Baldwin wrote:
> > > > This small patch makes the puc(4) bus drivers a little more friendly. It
> > > > should now list the port for each child device in the boot messages, and
> > > > devinfo -v should list the type and port of each child device in its output as
> > > > well:
> > >
> > > Can I get a volunteer to test these changes?
> > >
> > Would it be OK to use r202285 as a base for your patch?
> > If so, I will test it today/tomorrow. If not, it will take a little bit
> > longer...
>
> Yes, it should apply fine to that. It doesn't touch pucdata.c which is the
> only thing in the puc driver that has changed since that revision. Thanks!
>
Seems to work fine. Attached are relevant diff-s of dmesg.boot and
devinfo -v output.
Alexey.
--LQksG6bCIzRHxTLp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="dmesg.boot_diff"
--- dmesg.boot_old 2011-06-15 16:18:52.000000000 +0200
+++ dmesg.boot_new 2011-06-15 16:23:56.000000000 +0200
@@ -49,11 +49,11 @@
pcm0: <Analog Devices AD1881A AC97 Codec>
puc0: <NetMos NM9835 Dual UART and 1284 Printer port> port 0x7c00-0x7c07,0x8000-0x8007,0x8400-0x8407,0x8800-0x8807,0x8c00-0x8c07,0x9000-0x900f irq 7 at device 10.0 on pci0
puc0: [FILTER]
-uart2: <Non-standard ns8250 class UART with FIFOs> on puc0
+uart2: <Non-standard ns8250 class UART with FIFOs> at port 1 on puc0
uart2: [FILTER]
-uart3: <Non-standard ns8250 class UART with FIFOs> on puc0
+uart3: <Non-standard ns8250 class UART with FIFOs> at port 2 on puc0
uart3: [FILTER]
-ppc0: <Parallel port> on puc0
+ppc0: <Parallel port> at port 3 on puc0
ppc0: SMC-like chipset (ECP/EPP/PS2/NIBBLE) in COMPATIBLE mode
ppc0: FIFO with 16/16/12 bytes threshold
ppbus0: <Parallel port bus> on ppc0
--LQksG6bCIzRHxTLp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=devinfo_diff
--- devinfo_old 2011-06-15 16:19:03.000000000 +0200
+++ devinfo_new 2011-06-15 16:24:02.000000000 +0200
@@ -38,9 +38,9 @@
hostb1 pnpinfo vendor=0x1106 device=0x3057 subvendor=0x0000 subdevice=0x0000 class=0x060000 at slot=7 function=4 handle=\_SB_.PCI0.VTAC
pcm0 pnpinfo vendor=0x1106 device=0x3058 subvendor=0x11d6 subdevice=0x7358 class=0x040100 at slot=7 function=5
puc0 pnpinfo vendor=0x9710 device=0x9835 subvendor=0x1000 subdevice=0x0012 class=0x078000 at slot=10 function=0
- uart2
- uart3
- ppc0
+ uart2 pnpinfo type=1 at port=1
+ uart3 pnpinfo type=1 at port=2
+ ppc0 pnpinfo type=2 at port=3
ppbus0
plip0
lpt0
--LQksG6bCIzRHxTLp--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110615152601.GA65255>