Date: Mon, 3 Oct 2005 10:20:28 GMT From: Yar Tikhiy <yar@comp.chem.msu.su> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/86618: [if_nge] [panic] panic with ifconfig nge Message-ID: <200510031020.j93AKSg9062625@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/86618; it has been noted by GNATS. From: Yar Tikhiy <yar@comp.chem.msu.su> To: freebsd-gnats-submit@FreeBSD.org Cc: Subject: Re: kern/86618: [if_nge] [panic] panic with ifconfig nge Date: Mon, 3 Oct 2005 14:13:26 +0400 For the record: here is a detailed explanation of the problem from Yuriy. ----- Forwarded message from "Yuriy N. Shkandybin" <jura@networks.ru> ----- From: "Yuriy N. Shkandybin" <jura@networks.ru> To: Yar Tikhiy <yar@FreeBSD.org> Subject: Re: kern/83011: nge vlans broken Date: Mon, 3 Oct 2005 14:06:45 +0400 Absolutely! There is nge_stop() call from nge_init_locked() it's might be noticed from traces i've provided. Also i suppose problem appears due static nge nge_rx_list and nge_tx_list allocation in struct nge_list_data This leads to trash appeares here and when for (i = 0; i < NGE_RX_LIST_CNT; i++) { if (sc->nge_ldata->nge_rx_list[i].nge_mbuf != NULL) { m_freem(sc->nge_ldata->nge_rx_list[i].nge_mbuf); sc->nge_ldata->nge_rx_list[i].nge_mbuf = NULL; } } performed wrong sc->nge_ldata->nge_rx_list[i].nge_mbuf appeares and this leads to crash. Jura >On Mon, Oct 03, 2005 at 06:50:18AM +0000, Yuriy N. Shkandybin wrote: >> >> Sure i've tested and it's definitely fixed. > >Thanks! > >> I've got another bug with this driver >> See PR 86618 > >Alas, I have no nge(4) hardware, so I posted a message >to freebsd-net asking people to review PR 86618. The >problem description looks nearly correct to me though. >The only odd point I noticed was that nge_stop was called >in responce to "ifconfig nge0 up" command. Are you sure >it wasn't "ifconfig nge0 down"? > >-- >Yar > ----- End forwarded message ----- -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510031020.j93AKSg9062625>