Date: Tue, 20 Jul 2010 10:13:03 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Pyun YongHyeon <yongari@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210263 - head/sys/dev/bce Message-ID: <20100720101118.H57851@maildrop.int.zabbadoz.net> In-Reply-To: <201007192141.o6JLfsr3090971@svn.freebsd.org> References: <201007192141.o6JLfsr3090971@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 19 Jul 2010, Pyun YongHyeon wrote: > Author: yongari > Date: Mon Jul 19 21:41:54 2010 > New Revision: 210263 > URL: http://svn.freebsd.org/changeset/base/210263 > > Log: > Do not report current link state if interface is not UP. Hmm, not sure what exactly the code change does but by your description I think I would like to be able to see a porper (updated) result in the media: line of ifconfig no matter if it's UP or not. If this doesn't change that behaviour, just ignore me;) > Reviewed by: davidch > > Modified: > head/sys/dev/bce/if_bce.c > > Modified: head/sys/dev/bce/if_bce.c > ============================================================================== > --- head/sys/dev/bce/if_bce.c Mon Jul 19 21:38:15 2010 (r210262) > +++ head/sys/dev/bce/if_bce.c Mon Jul 19 21:41:54 2010 (r210263) > @@ -5855,6 +5855,10 @@ bce_ifmedia_sts(struct ifnet *ifp, struc > > BCE_LOCK(sc); > > + if ((ifp->if_flags & IFF_UP) == 0) { > + BCE_UNLOCK(sc); > + return; > + } > mii = device_get_softc(sc->bce_miibus); > > mii_pollstat(mii); > -- Bjoern A. Zeeb From August on I will have a life. It's now up to you to do the maths and count to 64. -- Bondorf, Germany, 14th June 2010
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100720101118.H57851>