Date: Thu, 13 Apr 2000 16:08:46 -0700 (PDT) From: Kris Kennaway <kris@FreeBSD.org> To: Warner Losh <imp@village.org> Cc: "Jordan K. Hubbard" <jkh@zippy.cdrom.com>, Robin Melville <robmel@innotts.co.uk>, Doug Barton <Doug@gorean.org>, stable@FreeBSD.ORG Subject: Re: 4.0, OpenSSL and MD5 (fwd) Message-ID: <Pine.BSF.4.21.0004131606350.45420-100000@freefall.freebsd.org> In-Reply-To: <200004132239.QAA48615@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Apr 2000, Warner Losh wrote:
> Most of the rest. Things like NOPROFILE the value is also checked.
I beg to differ..bsd.lib.mk only does ".if defined(NOPROFILE)"
> Personally, I think *ALL* of them should be checked for yes vs no
> (both cases), but that would be a huge PITA to get right. However, it
> should be done in the least pain way, eg
>
> .if !defined(NOFOO) && ${NOFOO} != "no" && ${NOFOO} != "NO"
>
> so that you can have NOFOO?=yes in your make.conf file and still say
> NOFOO=no on the command line.
You're right that it would be a huge PITA :-) The checks are complicated
enough already - they simplify when you condense the various compatible
options together in Makefile.inc1, but it's still hairy. I'll try and
clean up my NOFOO -> NO_FOO patch in the next few days so we can move
forward in this area.
Kris
----
In God we Trust -- all others must submit an X.509 certificate.
-- Charles Forsythe <forsythe@alum.mit.edu>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0004131606350.45420-100000>