Date: Fri, 21 Aug 2015 08:29:23 -0500 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: Warner Losh <imp@bsdimp.com>, Dimitry Andric <dim@freebsd.org> Cc: Oliver Pinter <oliver.pinter@hardenedbsd.org>, current@freebsd.org, imp@freebsd.org Subject: Re: 11-CURRENT build fail with base gcc Message-ID: <55D727B3.801@FreeBSD.org> In-Reply-To: <30F511DD-2C7C-4252-8870-AC15B36FF36A@bsdimp.com> References: <CAPQ4ffuNzYQJHxuGKcJ%2BG5b47n-c7DjS6DJX9FrQFu9GGPrpbQ@mail.gmail.com> <B9AED518-76CC-4706-898F-65E72402ABD6@FreeBSD.org> <CAPQ4ffvEsRRhrLHoRhf4D3pUh%2BhnG_DBTHdQbdRNGbpT5Fk7kA@mail.gmail.com> <349EA432-E76D-4D1B-9383-E707967C806D@bsdimp.com> <BC306807-C29B-4629-AFFA-DA169541818B@FreeBSD.org> <30F511DD-2C7C-4252-8870-AC15B36FF36A@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/20/2015 14:21, Warner Losh wrote: > >> On Aug 20, 2015, at 10:32 AM, Dimitry Andric <dim@freebsd.org> wrote: >> >> Ah, this should be replaced with the recently introduced CFLAGS_NO_SIMD >> variable, then? > > Perhaps. Didn’t know this was a thing. That could use useful many places, though > there were two clang specific args I needed to move, not just the one that’s in this > flag. Maybe things are over-specified? > > Not sure I like bsd.cpu.mk growing more name-space pollution, especially stuff that > isn’t documented somewhere (bsd.cpu.mk is included from sys.mk, which is automaticallyed > globally included). I couldn't find any _good_ place for it, so I stuck it in the least bad place. I also didn't know where to document it. I'll gladly move it and document it if someone can suggest good locations. > All these hacks being stashed hither and yon are starting to get > very hard to keep straight for someone who looks at this code every day, let alone > somebody who invested CFLAGS_NO_SIMD independently for their code and finds > that breaks in an upgrade...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55D727B3.801>