Date: Fri, 22 Sep 2000 14:43:21 +0930 From: Greg Lehey <grog@lemis.com> To: "Brandon D. Valentine" <bandix@looksharp.net> Cc: Matthew Jacob <mjacob@feral.com>, Poul-Henning Kamp <phk@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: 1131 unneeded includes in the kernel... Message-ID: <20000922144321.F66887@wantadilla.lemis.com> In-Reply-To: <Pine.BSF.4.21.0009200302350.95779-100000@turtle.looksharp.net>; from bandix@looksharp.net on Wed, Sep 20, 2000 at 03:10:21AM -0400 References: <Pine.BSF.4.21.0009192356270.2289-100000@beppo.feral.com> <Pine.BSF.4.21.0009200302350.95779-100000@turtle.looksharp.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, 20 September 2000 at 3:10:21 -0400, Brandon D. Valentine wrote: > On Tue, 19 Sep 2000, Matthew Jacob wrote: > >> >> Oh- don't get me wrong. Valuable info. Thanks. > > What would be very cool is to feed this into another script which strips > these unnecesary includes out. Then do a test build of LINT in your > local tree and if it succeeds commit a mass removal of them. The same > concept could be applied to the greater source tree. Things aren't that simple. I've checked some of the vinum ones, and I find something like: #ifdef VINUMDEBUG #include <sys/reboot.h> #endif sys/reboot.h has been flagged as unnecessary. Obviously the #ifdef's have to do as well--if the script is correct. There are a number of options in Vinum which never get as far as the source tree. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000922144321.F66887>