Date: Tue, 22 Jun 2021 17:38:26 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Dmitry Chagin <dchagin@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: e013e36939ac - main - linux(4): Get rid of Linuxulator kernel build options. Message-ID: <202106230038.15N0cQBT073502@gndrsh.dnsmgr.net> In-Reply-To: <C06B43AE-D887-410F-A212-5A16BC28DDB7@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > On 21 Jun 2021, at 17:56, Dmitry Chagin <dchagin@FreeBSD.org> wrote: > > > > The branch main has been updated by dchagin: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=e013e36939ac87b53195370fb5e29f29c1a4b5c6 > > > > commit e013e36939ac87b53195370fb5e29f29c1a4b5c6 > > Author: Dmitry Chagin <dchagin@FreeBSD.org> > > AuthorDate: 2021-06-22 05:32:39 +0000 > > Commit: Dmitry Chagin <dchagin@FreeBSD.org> > > CommitDate: 2021-06-22 05:32:39 +0000 > > > > linux(4): Get rid of Linuxulator kernel build options. > > > > Stop confusing people, retire COMPAT_LINUX and COMPAT_LINUX32 kernel > > build options. Since we have 32 and 64 bit Linux emulators, we can't build both > > emulators together into the kernel. I don't think it matters, Linux emulation > > depends on loadable modules (via rc). > > > > Cut LINPROCFS and LINSYSFS for consistency. > > I don?t see why these two should be deleted? They currently build fine, > and GNU/kFreeBSD kernels enable them. They might work as modules, but I > would worry that too many parts of userland would try and read them > before /etc/init.d/kldutils (the init script that loads modules) loads > them, so then we?d have to mess around with GRUB configs to preload > them. If the options work, please leave them in. I also see no good reason to remove these options, and it well actually break some of my systems as I do NOT use loadable modules in my deployed systems, and some of them use the LINUXulator. Further anything that can be built as a module should also be supported as a compiled in kernel option, people just expect that to work. > > There?s a separate debate of whether this is the ?right? fix for > COMPAT_LINUX*; arguably that *should* work and it?s a bug that they > don?t, not a feature, even if it?s not of much interest to support? > > I?d like to see the second half reverted, please, and believe the first > should be too, but I feel less strongly about that. > > Jess > > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202106230038.15N0cQBT073502>