Date: Tue, 23 Sep 2025 18:30:59 GMT From: Michael Tuexen <tuexen@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 43bbecaeb95f - main - tcp lro: remove redundant check Message-ID: <202509231830.58NIUxc2038589@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=43bbecaeb95fe5ea1d7acffab4f2874247ba6915 commit 43bbecaeb95fe5ea1d7acffab4f2874247ba6915 Author: Michael Tuexen <tuexen@FreeBSD.org> AuthorDate: 2025-09-23 18:28:54 +0000 Commit: Michael Tuexen <tuexen@FreeBSD.org> CommitDate: 2025-09-23 18:28:54 +0000 tcp lro: remove redundant check Remove a check which is also done in tcp_lro_rx_common(). Reviewed by: gallatin MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D52683 --- sys/netinet/tcp_lro.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/sys/netinet/tcp_lro.c b/sys/netinet/tcp_lro.c index 7512679bd4e9..64efa4bf060f 100644 --- a/sys/netinet/tcp_lro.c +++ b/sys/netinet/tcp_lro.c @@ -1428,17 +1428,6 @@ tcp_lro_rx(struct lro_ctrl *lc, struct mbuf *m, uint32_t csum) { int error; - if (((m->m_pkthdr.csum_flags & (CSUM_DATA_VALID | CSUM_PSEUDO_HDR)) != - ((CSUM_DATA_VALID | CSUM_PSEUDO_HDR))) || - (m->m_pkthdr.csum_data != 0xffff)) { - /* - * The checksum either did not have hardware offload - * or it was a bad checksum. We can't LRO such - * a packet. - */ - counter_u64_add(tcp_bad_csums, 1); - return (TCP_LRO_CANNOT); - } /* get current time */ binuptime(&lc->lro_last_queue_time); CURVNET_SET(lc->ifp->if_vnet);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202509231830.58NIUxc2038589>