Date: Mon, 3 Mar 2003 20:36:37 -0500 (EST) From: Jeff Roberson <jroberson@chesapeake.net> To: Alfred Perlstein <bright@mu.org> Cc: src-committers@FreeBSD.org, <cvs-src@FreeBSD.org>, <cvs-all@FreeBSD.org>, <bde@FreeBSD.org> Subject: Re: cvs commit: src/sys/kern vfs_default.c Message-ID: <20030303203530.D72102-100000@mail.chesapeake.net> In-Reply-To: <20030304005638.GH43089@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 3 Mar 2003, Alfred Perlstein wrote: > * Jeff Roberson <jroberson@chesapeake.net> [030303 16:39] wrote: > > On Mon, 3 Mar 2003, Alfred Perlstein wrote: > > > > Log: > > > > - Correct the wchan in vop_stdfsync() > > > > > > > > This is almost what bde asked for. There is some desire to have per fs wchans > > > > still but that is difficult giving the current arrangement of the code. > > > > char wchanbuf[7] = " sync"; > > wchanbuf[0] = vp->v_type[0]; > > wchanbuf[1] = vp->v_type[1]; > > Although I provided that intial suggestion I'm actually opposed to > non-const strings being passed into tsleep. The reaon being, if > someone gets a process wedged, it should be trivial to grep for the > wchan that it's stuck in. Adding something like this, while pretty > actually would make it harder to debug things later. > > While this one exception wouldn't be too bad I'm afraid it will lead > to (un)clever abuses later. > Any comments bde? This seems like a bit of a judgement call to me. I'm not sure which I prefer. Cheers, Jeff To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030303203530.D72102-100000>