Date: Mon, 24 Oct 2011 16:55:23 +0300 From: "Luchesar V. ILIEV" <luchesar.iliev@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Garrett Cooper <yanegomi@gmail.com>, Craig Rodrigues <rodrigc@crodrigues.org>, freebsd-current@freebsd.org, Doug Barton <dougb@freebsd.org> Subject: Re: sys/conf/newvers.sh vs. subversion-1.7 Message-ID: <4EA56E4B.9090802@gmail.com> In-Reply-To: <201110240759.54727.jhb@freebsd.org> References: <20111020114844.GK59810@albert.catwhisker.org> <alpine.BSF.2.00.1110220801140.38610@toaster.local> <4EA2EFDD.4020507@gmail.com> <201110240759.54727.jhb@freebsd.org>
index | next in thread | previous in thread | raw e-mail
On 24/10/2011 14:59, John Baldwin wrote:
> On Saturday, October 22, 2011 12:31:25 pm Luchesar V. ILIEV wrote:
>> Speaking of that, and in the context of the recursion that svnversion
>> does, something else comes to my mind...
>>
>> svnversion is currently executed in ${SRCDIR}/sys, so the revision
>> number is relevant only to the kernel sources. But FreeBSD is not just a
>> kernel, unlike Linux, so wouldn't it make more sense to actually check
>> the revision directly at ${SRCDIR}, thus catching possible different
>> revisions in other parts of the base system source tree?
>
> Please no. That makes svnversion take a _lot_ longer. We used to do that,
> but changed it. Also, the kernel build does not use any sources outside
> of sys/, so for the kernel an svnversion of sys/ is perfectly reasonable.
>
Sorry, it's my fault not noticing that it used to be that way. I also
guess that the topic has been discussed, so I'm sure all the pros and
cons have been well weighted. Thanks for the clarification.
Cheers,
Luchesar
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EA56E4B.9090802>