Date: Thu, 16 Jun 2016 10:43:53 -0700 From: Ngie Cooper <yaneurabeya@gmail.com> To: cem@freebsd.org Cc: Konstantin Belousov <kib@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301959 - head/sys/kern Message-ID: <E27E4A0B-949C-4DCA-A9D4-B3B822E13C18@gmail.com> In-Reply-To: <CAG6CVpXDDk6uQLrj7dgjP5aNhQoq_uwF1n3eHy83Qq9E0GEeEw@mail.gmail.com> References: <201606161158.u5GBwkd1042632@repo.freebsd.org> <CAG6CVpXDDk6uQLrj7dgjP5aNhQoq_uwF1n3eHy83Qq9E0GEeEw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 16, 2016, at 10:17, Conrad Meyer <cem@freebsd.org> wrote: >=20 >> On Thu, Jun 16, 2016 at 4:58 AM, Konstantin Belousov <kib@freebsd.org> wr= ote: >> --- head/sys/kern/kern_thread.c Thu Jun 16 11:55:24 2016 (r301958)= >> +++ head/sys/kern/kern_thread.c Thu Jun 16 11:58:46 2016 (r301959)= >> @@ -669,11 +669,6 @@ weed_inhib(int mode, struct thread *td2, >> wakeup_swapper |=3D sleepq_abort(td2, EINTR); >> break; >> case SINGLE_BOUNDARY: >> - if (TD_IS_SUSPENDED(td2) && (td2->td_flags & TDF_BOUNDARY= ) =3D=3D 0) >> - wakeup_swapper |=3D thread_unsuspend_one(td2, p, f= alse); >> - if (TD_ON_SLEEPQ(td2) && (td2->td_flags & TDF_SINTR) !=3D= 0) >> - wakeup_swapper |=3D sleepq_abort(td2, ERESTART); >> - break; >=20 > style(9) nit: /* FALLTHROUGH */ >=20 Also, coverity will complain about the missing break unless that's there... > Best, > Conrad >=20 >> case SINGLE_NO_EXIT: >> if (TD_IS_SUSPENDED(td2) && (td2->td_flags & TDF_BOUNDARY)= =3D=3D 0) >> wakeup_swapper |=3D thread_unsuspend_one(td2, p, f= alse); >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E27E4A0B-949C-4DCA-A9D4-B3B822E13C18>