Date: Fri, 23 Jan 2015 16:35:00 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: freebsd-current@FreeBSD.org Subject: Re: OptionalObsoleteFiles.inc completeness improvement, try 2 Message-ID: <4F0C24D1-9313-49BC-992E-5C31DAC6DADC@gmail.com> In-Reply-To: <20150124002956.GI1101@hades.panopticon> References: <20150124002956.GI1101@hades.panopticon>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Jan 23, 2015, at 16:29, Dmitry Marakasov <amdmi3@amdmi3.ru> wrote: > Hi! > > Some years ago I've started a project of improving > OptionalObsoleteFiles.inc completeness, which allows make delete-old > / delete-old-libs / delete-old-dirs targets completelty remove files > which are normally installed when specific src.conf WITHOUT_* knobs > are set. > > In other words, if a user has some WITHOUT_* set in src.conf, > specific files are not installed by installworld, but not removed > by remove-old, which I try to fix. > > In yet other words, I want to make it so `make installworld > -DWITHOUT_foo=yes` and `make installworld && make delete-old > -DWITHOUT_foo=yes` result in the very same file sets. > > Though the project seems to be useful and have real demand (added > to IdeasPage by netchild@, though removed later by brooks@ [1]) > and interest ([2]), the change was ignored back then and now the > patch is completely rotten. I can redo it, but I need a reviewer. > Here's a first small part of the patch: > > https://reviews.freebsd.org/D1600 > > The WIP branch with other changes is [3] > > Also there is a question of delete-old-dirs removing directories > which are created by mtree run by installworld unconditionally. > This seems to be incorrect - either directories should be installed > conditionally or not removed by delete-old-dirs. My patch will > address this issue as well, by not remiving unconditionally installed > dirs. > > [1] https://wiki.freebsd.org/action/diff/IdeasPage?action=diff&rev1=260&rev2=261 > [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=168341#c6 > [3] https://github.com/AMDmi3/freebsd/compare/obsolete-files Hi Dmitry, Seems like we’ve duplicated work a bit. Have you looked at ^/projects/building-blocks yet ? Thanks! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUwui0AAoJEMZr5QU6S73eahwIAIKBn5dnwfkueF0nHPdKNzYq aVCfjVrTXobTHmkrz1/PrKanqDRVdOYpBzcDZwVXLyJjIg6+Q38YSnEp0PpRGMff l/IbGsG6iQVyCFan1qK8PCygdGDw7X9vT3RJzMr+wIAFQ1o5Al0mgU8TUuAl5yAR rxUxw/5mkTGw8w1W/ZFTVzliWT6yJQq+CIeXXPR15hSUGcQ61/ivLFM16LL2mMV1 mFBsBjonnZfAKhHIPH68DqvRUm7U4ZfVg7uA3eclQuDJ6ULr42pZJXxwO9BRmMkw V81+dchwpPrOR6RHckCyAi8D8AogWNw+LCh8IAR6n3sEWS7Y+zSU9sRv9LR4FyE= =FRW5 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F0C24D1-9313-49BC-992E-5C31DAC6DADC>