Date: Fri, 15 Dec 2006 08:25:39 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Diego Giagio <dgiagio@gmail.com> Cc: trustedbsd-audit@FreeBSD.org Subject: Re: OpenBSM compiler warnings patch Message-ID: <20061215082453.R29087@fledge.watson.org> In-Reply-To: <4560D883.7040409@gmail.com> References: <4560D883.7040409@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 19 Nov 2006, Diego Giagio wrote: > I've created a patch that removes all the compiler warnings I was getting, > mostly signed/unsigned stuff. > > bsm_io.c: I've sticked with the following rules to resolve the conflicts: > > - Buffers are u_char* > - Strings are char* (or const char*) > - Casts are used when pointing strings inside buffers. > > bsm_notify.c: notify_check function on my Mac OS X 10.4.8 expects an int on > the second parameter, not an unsigned int. > > bsm_token.c: au_to_newgroups expect a gid_t* on the second parameter, not an > int*. In fact a gid_t may expand to an int or even an unsigned int. > > Instructions: > $ cd openbsm > $ patch -p1 < warnings.patch > > Please review. Diego, Sorry for the long delay in getting back to you on this. I've installed gcc41 on my desktop box, confirmed the warning fixes, and merged to Perforce. These changes will appear starting in OpenBSM 1.0 alpha 14. Thanks! Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061215082453.R29087>