Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 Jul 2005 08:35:46 -0600
From:      Scott Long <scottl@samsco.org>
To:        Xin LI <delphij@frontfree.net>
Cc:        re@FreeBSD.org, freebsd-arch@FreeBSD.org
Subject:   Re: [PATCH] Remove ENABLE_SSE option from i386 and pc98
Message-ID:  <42C554C2.5050304@samsco.org>
In-Reply-To: <20050701111103.GA48039@frontfree.net>
References:  <20050701111103.GA48039@frontfree.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Xin LI wrote:

> Hi,
> 
> Here is a patch for review, which removes ENABLE_SSE from i386 and
> pc98 platforms.  I think we should have it before we branch RELENG_6.
> 
> The reason why the option should be removed:
> 
> 	- ENABLE_SSE was turned on by default 2 years and 9 months
> 	  ago, for I686_CPU.  It makes few sense to "enable" something
> 	  that is already enabled (No I586_CPUs supports SSE so far
> 	  as I am aware)
> 	- We have DISABLE_SSE to disable SSE, having both ENABLE_SSE
> 	  and DISABLE_SSE is quite confusing, since DISABLE_SSE
> 	  always overrides ENABLE_SSE.
> 
> Cheers,

Approved.  Please commit it today if possible.

Scott



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42C554C2.5050304>