Date: Sat, 21 Oct 2006 22:07:16 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Don Lewis <truckman@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, davidxu@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_exit.c Message-ID: <20061022020716.GA29912@xor.obsecurity.org> In-Reply-To: <200610220014.k9M0E5mG061752@gw.catspoiler.org> References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610220014.k9M0E5mG061752@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 21, 2006 at 05:14:05PM -0700, Don Lewis wrote: > On 21 Oct, David Xu wrote: > > davidxu 2006-10-21 23:59:15 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/kern kern_exit.c=20 > > Log: > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > > opened a race window which can cause memory leak in signal queue. > > Here we free memory for signal queue when process state is set to > > PRS_ZOMBIE. > > =20 > > Revision Changes Path > > 1.291 +8 -2 src/sys/kern/kern_exit.c >=20 > I wonder if the earlier change is what broke portupgrade after I > upgraded from an August 31st version of current to yesterday's version. > The symptoms were random processes dying from SIGHUP. It was easy to > reproduce by just going to a port directory and running > script foo make clean > a few times. I'd randomly see make complain about a non-zero exit > status from uname or some other sub-process. I tracked the problem back > to the SIGHUP bit being set in td2's sigqueue in fork1(). As a > workaround, I added a call to sigqueue_init() where td2 gets bzero'ed. Something is making java segfault reproducibly on a recent kernel too. I'll test to see whether this fixes it. Kris --DocE+STaALJfprDB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFOtJUWry0BWjoQKURAoaMAKDsl/UFHao/r6WjlWkK+WhQyWagQACeLLIu 5E8YovHpQFbvrUj/tO1fyxM= =gu5c -----END PGP SIGNATURE----- --DocE+STaALJfprDB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061022020716.GA29912>