Date: Tue, 26 Apr 2011 14:53:33 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Hans Petter Selasky <hselasky@c2i.net> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r221059 - in head/sys: kern sys Message-ID: <20110426115333.GP48734@deviant.kiev.zoral.com.ua> In-Reply-To: <201104261344.00551.hselasky@c2i.net> References: <201104261139.p3QBduVx020817@svn.freebsd.org> <201104261344.00551.hselasky@c2i.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Tue, Apr 26, 2011 at 01:44:00PM +0200, Hans Petter Selasky wrote:
> On Tuesday 26 April 2011 13:39:56 Konstantin Belousov wrote:
> > + pending = !!callout_stop(&timeout_task->c);
>
> pending = (callout_stop(&timeout_task->c) != 0);
>
> ?
This line is about conversion from a boolean value to {0, 1} value set.
If !! construct does not look stylish, then wouldn't we need to go
with
pending = (callout_stop(&timeout_task->c) != 0) ? 1 : 0;
instead ?
Feel free to adjust whatever variant you prefer and commit it.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEARECAAYFAk22sj0ACgkQC3+MBN1Mb4ggfQCgrvHcDN6+1Y8WuU04AIfPN5oH
rxcAn33A6RRjpgu/pRYwVZKSbeNc3H9f
=9Eou
-----END PGP SIGNATURE-----
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110426115333.GP48734>