Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 May 2021 07:54:07 +0200
From:      Lutz Donnerhacke <lutz@donnerhacke.de>
To:        Joe Clarke <jclarke@marcuscom.com>, Zhenlei Huang <zlei.huang@gmail.com>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 3d846e48227e - main - Do not forward datagrams originated by link-local addresses
Message-ID:  <20210519055407.GA9715@belenus.iks-jena.de>
In-Reply-To: <D759CEBE-115A-404D-B12C-20A673923092@marcuscom.com>
References:  <202105182101.14IL1Gki054229@gitrepo.freebsd.org> <D759CEBE-115A-404D-B12C-20A673923092@marcuscom.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 18, 2021 at 07:51:38PM -0400, Joe Clarke wrote:
> Just out of curiosity, why remove the RFC reference from the comment?

May you please include the author of the change for such questions?

> > commit 3d846e48227e2e78c1e7b35145f57353ffda56ba
> > Author:     Zhenlei Huang <zlei.huang@gmail.com>
> > AuthorDate: 2021-05-18 20:51:37 +0000
> > Commit:     Lutz Donnerhacke <donner@FreeBSD.org>
> > CommitDate: 2021-05-18 20:59:46 +0000
> > 
> >    The current implement of ip_input() reject packets destined for
> >    169.254.0.0/16, but not those original from 169.254.0.0/16 link-local
> >    addresses.
> > 
> >    Fix to fully respect RFC 3927 section 2.7.
> > 
> >    PR:             255388
> >    Reviewed by:    donner, rgrimes, karels
> >    MFC after:      1 month
> >    Differential Revision:  https://reviews.freebsd.org/D29968

I did only commit this differential, but set a month for MFC, exactly to
have to opportunity to fix such mistakes.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210519055407.GA9715>