Date: Tue, 16 Nov 2004 17:00:47 +0300 (MSK) From: Dmitry Morozovsky <marck@rinet.ru> To: Giorgos Keramidas <keramida@freebsd.org> Cc: freebsd-bugs@freebsd.org Subject: Re: misc/73992: periodic security not showing faily firewall diffs Message-ID: <20041116165859.C57439@woozle.rinet.ru> In-Reply-To: <200411161200.iAGC0mir091454@freefall.freebsd.org> References: <200411161200.iAGC0mir091454@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 16 Nov 2004, Giorgos Keramidas wrote: GK> Wouldn't a better fix be to change the default filter in check_diff() GK> to make sure the correct pattern is used? I'm thinking of something GK> like this: GK> GK> : Index: security.functions GK> : =================================================================== GK> : RCS file: /home/ncvs/src/etc/periodic/security/security.functions,v GK> : retrieving revision 1.4 GK> : diff -u -u -r1.4 security.functions GK> : --- security.functions 23 Sep 2004 02:00:51 -0000 1.4 GK> : +++ security.functions 16 Nov 2004 11:55:03 -0000 GK> : @@ -44,6 +44,9 @@ GK> : if [ "$1" = "new_only" ]; then GK> : shift GK> : filter="grep '^>'" GK> : + case $daily_status_security_diff_flags in GK> : + *-u*|*-c*) filter="grep '^+[^+]'" ;; GK> : + esac GK> : else GK> : filter="cat" GK> : fi It will miss changes in context diffs (they are marked by '!'), won't it? Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041116165859.C57439>