Date: Wed, 24 Feb 2010 15:52:18 +0000 (UTC) From: Brooks Davis <brooks@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r204278 - head/sys/kern Message-ID: <201002241552.o1OFqI0l031292@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: brooks Date: Wed Feb 24 15:52:18 2010 New Revision: 204278 URL: http://svn.freebsd.org/changeset/base/204278 Log: Don't inforce an upper bound on kern.ngroups. The INT_MAX-1 limit was too high due to several overflows. The actual limit is somewhere in the neighborhood of INT_MAX/4 on 64-bit machines, but most systems could not support such a limit due to a lack of memory and the cost of duplicate credentials. Reported by: bde Modified: head/sys/kern/subr_param.c Modified: head/sys/kern/subr_param.c ============================================================================== --- head/sys/kern/subr_param.c Wed Feb 24 15:27:31 2010 (r204277) +++ head/sys/kern/subr_param.c Wed Feb 24 15:52:18 2010 (r204278) @@ -240,8 +240,6 @@ init_param1(void) TUNABLE_INT_FETCH("kern.ngroups", &ngroups_max); if (ngroups_max < NGROUPS_MAX) ngroups_max = NGROUPS_MAX; - if (ngroups_max > INT_MAX - 1) - ngroups_max = INT_MAX - 1; } /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201002241552.o1OFqI0l031292>