Date: Tue, 26 Jun 2018 09:10:50 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= <royger@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: rgrimes@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga Message-ID: <20180626071050.cywzvicvddomiceh@mac.bytemobile.com> In-Reply-To: <20180626052127.GA19828@FreeBSD.org> References: <201806250939.w5P9dGMA067104@repo.freebsd.org> <201806251543.w5PFhp8g099163@pdx.rh.CN85.dnsmgr.net> <20180626052127.GA19828@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 26, 2018 at 05:21:27AM +0000, Alexey Dokuchaev wrote: > On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote: > > > New Revision: 335629 > > > URL: https://svnweb.freebsd.org/changeset/base/335629 > > > > > > Log: > > > vt: add option to ignore NO_VGA flag in ACPI > > > > > > To workaround buggy firmware that sets this flag when there's actually > > > a VGA present. > > > > > > Reported and tested by: Yasuhiro KIMURA <yasu@utahime.org> > > > Sponsored by: Citrix Systems R&D > > > Reviewed by: kib > > > Differential revision: https://reviews.freebsd.org/D16003 > > > > It is generally best to avoid double negatives, > > couldnt this of been better named? (hw.vga.acpi_force_vga) > > Yes please; I get constantly confused when calculating negatives and > often get them wrong. This is specifically done to workaround a firmware bug where some buggy firmwares set the NO_VGA flag in ACPI. So the option does exactly what the name says, it ignores the NO_VGA flag in ACPI. IMO acpi_force_vga is not as descriptive as the current name. Roger.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180626071050.cywzvicvddomiceh>